[webkit-reviews] review granted: [Bug 202341] Web Inspector: Sources: enable tab by default : [Attachment 379800] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 10 13:54:54 PDT 2019
Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 202341: Web Inspector: Sources: enable tab by default
https://bugs.webkit.org/show_bug.cgi?id=202341
Attachment 379800: Patch
https://bugs.webkit.org/attachment.cgi?id=379800&action=review
--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 379800
--> https://bugs.webkit.org/attachment.cgi?id=379800
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=379800&action=review
r=me!
> Source/WebInspectorUI/UserInterface/Base/Main.js:145
> + WI.SourcesTabContentView,
This should have a `.Type` suffix.
> Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js:105
>
Style: Lets remove this extra newline while we are here.
More information about the webkit-reviews
mailing list