[webkit-reviews] review granted: [Bug 202778] [Cocoa] font-family:system-ui on Chinese systems don't get Chinese quote marks : [Attachment 380600] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 202778: [Cocoa] font-family:system-ui on Chinese systems don't get Chinese
quote marks
https://bugs.webkit.org/show_bug.cgi?id=202778

Attachment 380600: Patch

https://bugs.webkit.org/attachment.cgi?id=380600&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 380600
  --> https://bugs.webkit.org/attachment.cgi?id=380600
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380600&action=review

> Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:53
> +    if (locale && !CFStringGetLength(locale))
> +	   locale = nullptr;

Should we detect an empty locale in the calling chain?