[webkit-reviews] review granted: [Bug 202627] [iOS] Unmuting capture of a page is not working : [Attachment 380317] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 202627: [iOS] Unmuting capture of a page is not working
https://bugs.webkit.org/show_bug.cgi?id=202627

Attachment 380317: Patch

https://bugs.webkit.org/attachment.cgi?id=380317&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 380317
  --> https://bugs.webkit.org/attachment.cgi?id=380317
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380317&action=review

> Source/WebCore/ChangeLog:8
> +	   Before the patch, we were muting the captur tracks but never
unmuting them.

s/captur/capture/

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:479
> +void MediaStreamTrack::updateCaptureAccordingMutedState(Document& document)

Nit: updateCaptureAccordingToMutedState would be slightly clearer.