[webkit-reviews] review granted: [Bug 202628] WebPageProxy::updatePlayingMediaDidChange should protect from a null m_userMediaPermissionRequestManager : [Attachment 380312] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 202628: WebPageProxy::updatePlayingMediaDidChange should protect from a
null m_userMediaPermissionRequestManager
https://bugs.webkit.org/show_bug.cgi?id=202628

Attachment 380312: Patch

https://bugs.webkit.org/attachment.cgi?id=380312&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 380312
  --> https://bugs.webkit.org/attachment.cgi?id=380312
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380312&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:8309
> +	   ASSERT(m_userMediaPermissionRequestManager);

If we expect m_userMediaPermissionRequestManager to be NULL some of the time,
do we really want an ASSERT here?