[webkit-reviews] review granted: [Bug 202432] focus pseudo class should match a shadow host whose shadow tree contains the focused element : [Attachment 380188] Updates the behavior

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 3 23:56:04 PDT 2019


Antti Koivisto <koivisto at iki.fi> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 202432: focus pseudo class should match a shadow host whose shadow tree
contains the focused element
https://bugs.webkit.org/show_bug.cgi?id=202432

Attachment 380188: Updates the behavior

https://bugs.webkit.org/attachment.cgi?id=380188&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 380188
  --> https://bugs.webkit.org/attachment.cgi?id=380188
Updates the behavior

View in context: https://bugs.webkit.org/attachment.cgi?id=380188&action=review

> Source/WebCore/dom/Element.cpp:682
> +	   root->setContainsFocusedElement(flag);

I suppose setFocus is already guaranteed to be called consistently in all DOM
mutations? This sort of stuff easily leaves stuck flags behind.


More information about the webkit-reviews mailing list