[webkit-reviews] review granted: [Bug 202491] Fix determination of the top-level resource : [Attachment 380053] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 3 23:51:38 PDT 2019


youenn fablet <youennf at gmail.com> has granted Keith Rollin
<krollin at apple.com>'s request for review:
Bug 202491: Fix determination of the top-level resource
https://bugs.webkit.org/show_bug.cgi?id=202491

Attachment 380053: Patch

https://bugs.webkit.org/attachment.cgi?id=380053&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 380053
  --> https://bugs.webkit.org/attachment.cgi?id=380053
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380053&action=review

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:171
> +    m_networkActivityTracker =
m_connection->startTrackingResourceLoad(m_parameters.webPageID,
m_parameters.identifier, isMainResource() && isMainFrameLoad());

if isMainFrameLoad() is true, isMainResource() should also be true.
I think we can remove the isMainResource() check.


More information about the webkit-reviews mailing list