[webkit-reviews] review granted: [Bug 204473] Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'target.PageAgent.getCompositingBordersVisible') : [Attachment 384090] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 204473: Web Inspector: Uncaught Exception: TypeError: undefined is not an
object (evaluating 'target.PageAgent.getCompositingBordersVisible')
https://bugs.webkit.org/show_bug.cgi?id=204473

Attachment 384090: Patch

https://bugs.webkit.org/attachment.cgi?id=384090&action=review




--- Comment #2 from Brian Burg <bburg at apple.com> ---
Comment on attachment 384090
  --> https://bugs.webkit.org/attachment.cgi?id=384090
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384090&action=review

r=me

> Source/WebInspectorUI/UserInterface/Controllers/TargetManager.js:261
> +	   WI._backendTargetAvailablePromise.resolve();

This reads nice now.

> Source/WebInspectorUI/UserInterface/Controllers/TargetManager.js:273
> +	   WI._pageTargetAvailablePromise.resolve();

Ditto :)