[webkit-reviews] review granted: [Bug 204472] Simplify VisitedLinkStore process registration logic : [Attachment 384089] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 204472: Simplify VisitedLinkStore process registration logic
https://bugs.webkit.org/show_bug.cgi?id=204472

Attachment 384089: Patch

https://bugs.webkit.org/attachment.cgi?id=384089&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 384089
  --> https://bugs.webkit.org/attachment.cgi?id=384089
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384089&action=review

r=me

> Source/WebKit/UIProcess/VisitedLinkStore.cpp:46
> +    RELEASE_ASSERT(m_processes.computesEmpty());

FWIW, I think this function was supposed to be named computeIsEmpty().

>> Source/WebKit/UIProcess/WebProcessProxy.cpp:-386
>> -	m_visitedLinkStoresWithUsers.clear();
> 
> This means the visitedLinkStore will keep shutdown but still existing
processes.
> Can this create some changes of behavior?

Interesting point -- but I can't think of any consequence. We might try to send
a message to shut a process -- and then the message should be dropped.