[webkit-reviews] review granted: [Bug 203818] Proxy's [[OwnPropertyKeys]] is incorrect in DontEnumPropertiesMode::Exclude : [Attachment 382961] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 20 10:32:53 PST 2019

Keith Miller <keith_miller at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 203818: Proxy's [[OwnPropertyKeys]] is incorrect in

Attachment 382961: Patch


--- Comment #6 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 382961
  --> https://bugs.webkit.org/attachment.cgi?id=382961

View in context: https://bugs.webkit.org/attachment.cgi?id=382961&action=review

r=me with nit.

> Source/JavaScriptCore/runtime/ProxyObject.cpp:944
> +    EnumerationMode enumerationMode(DontEnumPropertiesMode::Include);

Nit: It seems like we only use this in one place below. Can you just pass
DontEnumPropertiesMode::Include to getOwnPropertyNames directly?

More information about the webkit-reviews mailing list