[webkit-reviews] review granted: [Bug 204405] Flaky JSC test: stress/stack-overflow-in-yarr-byteCompile.js.dfg-eager : [Attachment 383966] proposed patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 20 10:31:06 PST 2019
Alexey Proskuryakov <ap at webkit.org> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 204405: Flaky JSC test:
stress/stack-overflow-in-yarr-byteCompile.js.dfg-eager
https://bugs.webkit.org/show_bug.cgi?id=204405
Attachment 383966: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=383966&action=review
--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 383966
--> https://bugs.webkit.org/attachment.cgi?id=383966
proposed patch.
View in context: https://bugs.webkit.org/attachment.cgi?id=383966&action=review
> Source/JavaScriptCore/ChangeLog:9
> + $vm.allWithStackSize() manipulates the stack in ways that will freak
out ASan.
> + So, add SUPPRESS_ASAN to functionCallWithStackSize() to tell ASan to
ignore it.
Was there a separate bug where this was reported?
More information about the webkit-reviews
mailing list