[webkit-reviews] review denied: [Bug 203818] Proxy's [[OwnPropertyKeys]] is incorrect in DontEnumPropertiesMode::Exclude : [Attachment 382773] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has denied Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 203818: Proxy's [[OwnPropertyKeys]] is incorrect in
DontEnumPropertiesMode::Exclude
https://bugs.webkit.org/show_bug.cgi?id=203818

Attachment 382773: Patch

https://bugs.webkit.org/attachment.cgi?id=382773&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 382773
  --> https://bugs.webkit.org/attachment.cgi?id=382773
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382773&action=review

Nice! I put r- because I found a bug.

> Source/JavaScriptCore/runtime/ProxyObject.cpp:1081
> +    ASSERT(enumerationMode.includeJSObjectProperties());

"getOwnPropertyNames " is a part of public interface of JSObject. So, we allow
clients to call this "getOwnPropertyNames" function directly. Like,

object->methodTable(vm)->getOwnPropertyNames(object, ...);

So, this ASSERT is not correct. Can you fix it?