[webkit-reviews] review granted: [Bug 203798] AX: WKWebView does not shift Accessibility Focus for Catalyst : [Attachment 382774] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 4 14:46:37 PST 2019


Tim Horton <thorton at apple.com> has granted Eric Liang <ericliang at apple.com>'s
request for review:
Bug 203798: AX: WKWebView does not shift Accessibility Focus for Catalyst
https://bugs.webkit.org/show_bug.cgi?id=203798

Attachment 382774: Patch

https://bugs.webkit.org/attachment.cgi?id=382774&action=review




--- Comment #14 from Tim Horton <thorton at apple.com> ---
Comment on attachment 382774
  --> https://bugs.webkit.org/attachment.cgi?id=382774
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382774&action=review

> Source/WebKit/UIProcess/ios/AppKitSoftLink.h:38
> + at interface NSObject(NSAccessibilityRemoteUIElement_Private)
> +- (void)registerRemoteUIProcessIdentifier:(pid_t)pid;
> +- (void)unregisterRemoteUIProcessIdentifier:(pid_t)pid;
> + at end

These go in AppKitSPI, not AppKitSoftLink. Probably in a macCatalyst-only
section.

Also, the category name should have a space before the opening paren.


More information about the webkit-reviews mailing list