[webkit-reviews] review granted: [Bug 203733] TestWebKitAPI.EditorStateTests.TypingAttributesTextAlignmentStartEnd is flaky in iOS simulator : [Attachment 382584] Speculative fix

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 203733:
TestWebKitAPI.EditorStateTests.TypingAttributesTextAlignmentStartEnd is flaky
in iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=203733

Attachment 382584: Speculative fix

https://bugs.webkit.org/attachment.cgi?id=382584&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 382584
  --> https://bugs.webkit.org/attachment.cgi?id=382584
Speculative fix

View in context: https://bugs.webkit.org/attachment.cgi?id=382584&action=review

> Tools/TestWebKitAPI/EditingTestHarness.mm:197
> +    const NSTimeInterval loggingTimeout = 3;

I think you should consider not having a timeout here, just depending on the
test-wide timeout, to better integrate with e.g. --no-timeout