[webkit-reviews] review granted: [Bug 203728] macCatalyst: Get TestWebKitAPI running : [Attachment 382567] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 1 10:21:41 PDT 2019

Alexey Proskuryakov <ap at webkit.org> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 203728: macCatalyst: Get TestWebKitAPI running

Attachment 382567: Patch


--- Comment #7 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 382567
  --> https://bugs.webkit.org/attachment.cgi?id=382567

View in context: https://bugs.webkit.org/attachment.cgi?id=382567&action=review

We don't have any support for macCatalyst in build-webkit, do we?

> Tools/TestWebKitAPI/config.h:75
> +#import <WebKit/WebKitLegacy.h>
> +#endif

I see the explanation in ChangeLog, but it doesn't tell me why it's needed at
all - and for something as unexpected as this, a code comment would be

More information about the webkit-reviews mailing list