[webkit-reviews] review granted: [Bug 198244] iOS: Main frame should be scrollable when pinch zoomed or software keyboard is up : [Attachment 371024] Fixed a bug

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 198244: iOS: Main frame should be scrollable when pinch zoomed or software
keyboard is up
https://bugs.webkit.org/show_bug.cgi?id=198244

Attachment 371024: Fixed a bug

https://bugs.webkit.org/attachment.cgi?id=371024&action=review




--- Comment #16 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 371024
  --> https://bugs.webkit.org/attachment.cgi?id=371024
Fixed a bug

View in context: https://bugs.webkit.org/attachment.cgi?id=371024&action=review

>
LayoutTests/fast/scrolling/ios/body-overflow-hidden-height-100-percent-keyboard
.html:24
> +    // FIXME: Work around the bug that scrolling down after the software
keyborad is brought up for the very first time does not work.

keyborad

You should file a bug and reference it here.

>
LayoutTests/fast/scrolling/ios/body-overflow-hidden-height-100-percent-keyboard
.html:36
> +    await new Promise((resolve) => setTimeout(resolve, 100));

UIHelper.delayFor()

>
LayoutTests/fast/scrolling/ios/body-overflow-hidden-height-100-percent-zoomed-1
.html:31
> +    await new Promise((resolve) => setTimeout(resolve, 200));

UIHelper.delayFor()

>
LayoutTests/fast/scrolling/ios/body-overflow-hidden-height-100-percent-zoomed-2
.html:35
> +    await new Promise((resolve) => setTimeout(resolve, 200));

UIHelper.delayFor