[webkit-reviews] review granted: [Bug 195264] Web Inspector: CSS Changes: modifications aren't shared for rules that match multiple elements : [Attachment 370902] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 195264: Web Inspector: CSS Changes: modifications aren't shared for rules
that match multiple elements
https://bugs.webkit.org/show_bug.cgi?id=195264

Attachment 370902: Patch

https://bugs.webkit.org/attachment.cgi?id=370902&action=review




--- Comment #52 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 370902
  --> https://bugs.webkit.org/attachment.cgi?id=370902
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370902&action=review

r=me, nice work!

> LayoutTests/inspector/unit-tests/array-utilities-expected.txt:90
> +["a"], ["a","a"] => [["a",0],["a",1]]
> +["a","a"], ["a"] => [["a",0],["a",-1]]

I love how these are now in the "right" order :)

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:532
> +		   if (i > editCount)

This could have a comment like >537.

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:534
> +		       break;
> +		   for (let j = 0; j < currentArray.length; ++j) {

Style: missing newline

> Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js:429
> +	   let initialCSSProperties = this._initialState.visibleProperties;
> +	   let cssProperties = this.visibleProperties;

NIT: these can be inlined.

> Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.js:153
> +	   let initialCSSProperties = style.initialState.visibleProperties;
> +	   let cssProperties = style.visibleProperties;

NIT: these can be inlined.