[webkit-reviews] review granted: [Bug 197836] Event region computation should respect transforms : [Attachment 369836] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 14 09:03:47 PDT 2019

Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 197836: Event region computation should respect transforms

Attachment 369836: patch


--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 369836
  --> https://bugs.webkit.org/attachment.cgi?id=369836

View in context: https://bugs.webkit.org/attachment.cgi?id=369836&action=review

> Source/WebCore/ChangeLog:12
> +	   Add support for transforming regions. Non-rectlinear results use
enclosing rects.

Is it acceptable to just use enclosing rects?

> Source/WebCore/rendering/EventRegion.h:41
> +    EventRegionContext(EventRegion&);

We want "explicit" here since we wouldn’t want this to be done as a conversion.

> Source/WebCore/rendering/EventRegion.h:58
> +    EventRegionContext makeContext() { return { *this }; }

Not sure why we have this since EventRegionContext also has a public
constructor. And it’s only used in one place. I think we could do without it.
Not sure, it does seem a little more elegant than invoking a constructor.

> Source/WebCore/rendering/RenderLayer.cpp:4603
> +    auto oldTransfrom = context.getCTM();

Spelling error here: "transfrom".

More information about the webkit-reviews mailing list