[webkit-reviews] review granted: [Bug 194813] [iOS] Correctly handle overlapping regions for elements with a touch-action property : [Attachment 369410] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 9 00:40:55 PDT 2019


Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 194813: [iOS] Correctly handle overlapping regions for elements with a
touch-action property
https://bugs.webkit.org/show_bug.cgi?id=194813

Attachment 369410: Patch

https://bugs.webkit.org/attachment.cgi?id=369410&action=review




--- Comment #9 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 369410
  --> https://bugs.webkit.org/attachment.cgi?id=369410
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369410&action=review

r=me

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1342
> +	       if (!touchActions.contains(WebCore::TouchAction::PinchZoom))
> +		   _webView.scrollView.pinchGestureRecognizer.enabled = NO;

Where does this thing get reset?


More information about the webkit-reviews mailing list