[webkit-reviews] review requested: [Bug 196488] [CMake] Detect SSE2 at compile time : [Attachment 369473] Detect SSE2 with CMake

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 9 00:38:53 PDT 2019


Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 196488: [CMake] Detect SSE2 at compile time
https://bugs.webkit.org/show_bug.cgi?id=196488

Attachment 369473: Detect SSE2 with CMake

https://bugs.webkit.org/attachment.cgi?id=369473&action=review




--- Comment #45 from Xan Lopez <xan.lopez at gmail.com> ---
Created attachment 369473

  --> https://bugs.webkit.org/attachment.cgi?id=369473&action=review

Detect SSE2 with CMake

New patch.
- Rename FindSSE2.cmake to DetectSSE2.cmake, since this is not trying to find
any package in any meaningful way.
- Do not run the SSE2 check when crosscompiling, since the building machine
won't be the one running the binary anyway (this is what build-jsc does/did
too).


More information about the webkit-reviews mailing list