[webkit-reviews] review denied: [Bug 197650] [Curl] Suppress extra didReceiveAuthenticationChallenge call when accessing a server which checks basic auth. : [Attachment 369469] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Takashi Komori
<Takashi.Komori at sony.com>'s request for review:
Bug 197650: [Curl] Suppress extra didReceiveAuthenticationChallenge call when
accessing a server which checks basic auth.
https://bugs.webkit.org/show_bug.cgi?id=197650

Attachment 369469: Patch

https://bugs.webkit.org/attachment.cgi?id=369469&action=review




--- Comment #17 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 369469
  --> https://bugs.webkit.org/attachment.cgi?id=369469
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369469&action=review

> Source/WebCore/ChangeLog:7
> +

Please add the comment #0 here.

> LayoutTests/http/tests/misc/resources/certificate-and-authentication.php:13
> +parent.postMessage("loaded", "*");

Do you need to use postMessage? Can you use onload as well as
http/tests/ssl/certificate-validation.html .
If so, you can reuse a existing auth cgi.

And, I think it looks cool using async and await such like
http/tests/ssl/certificate-validation.html.