[webkit-reviews] review granted: [Bug 197641] Add a release assertion that Functions can only be constructed from non-null CompletionHandlers : [Attachment 369213] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 197641: Add a release assertion that Functions can only be constructed from
non-null CompletionHandlers
https://bugs.webkit.org/show_bug.cgi?id=197641

Attachment 369213: Patch

https://bugs.webkit.org/attachment.cgi?id=369213&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 369213
  --> https://bugs.webkit.org/attachment.cgi?id=369213
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369213&action=review

> Source/WTF/wtf/CompletionHandler.h:68
> +template<typename Out, typename... In>

Should we add a FIXME to indicate this is temporary? I don't this this would
stay a RELEASE_ASSERT() forever and it seems like a lot of extra code for a
debug ASSERT().