[webkit-reviews] review granted: [Bug 197648] Storage Access API: Make two changes requested by developers and complete refactoring and cleanup : [Attachment 369300] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted John Wilander <wilander at apple.com>'s
request for review:
Bug 197648: Storage Access API: Make two changes requested by developers and
complete refactoring and cleanup
https://bugs.webkit.org/show_bug.cgi?id=197648

Attachment 369300: Patch

https://bugs.webkit.org/attachment.cgi?id=369300&action=review




--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 369300
  --> https://bugs.webkit.org/attachment.cgi?id=369300
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369300&action=review

r=me with changes.

> Source/WebCore/dom/DocumentStorageAccess.cpp:60
> +    return "DocumentStorageAccess"_s;

I do not think this should have a _s prefix since this returns a const char*.

> Source/WebCore/dom/DocumentStorageAccess.cpp:109
> +	   page->chrome().client().hasStorageAccess(WTFMove(subFrameDomain),
WTFMove(topFrameDomain), frameID.value(), pageID.value(), [documentReference =
makeWeakPtr(*this), promise = WTFMove(promise)] (bool hasAccess) {

documentReference -> weakThis ?

>
LayoutTests/http/tests/storageAccess/deny-with-prompt-does-not-preserve-gesture
-expected.txt:8
> +Some tests failed.

This looks bad.