[webkit-reviews] review granted: [Bug 196334] JetStream 2 should not report time values as scores : [Attachment 366138] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 27 18:21:22 PDT 2019

Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 196334: JetStream 2 should not report time values as scores

Attachment 366138: patch


--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 366138
  --> https://bugs.webkit.org/attachment.cgi?id=366138

View in context: https://bugs.webkit.org/attachment.cgi?id=366138&action=review


> Websites/browserbench.org/JetStream2.0/JetStreamDriver.js:324
>	       const subTimes = benchmark.subTimes();

subTimes return scores, it is a bit tricky. But it seems that all the XXXTimes
in benchmarks now uses score (toScore()).
So I think we should rename these variables and methods at some point to
reflect that this is a score.

More information about the webkit-reviews mailing list