[webkit-reviews] review denied: [Bug 196315] All prototypes should call didBecomePrototype() : [Attachment 366136] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 196315: All prototypes should call didBecomePrototype()
https://bugs.webkit.org/show_bug.cgi?id=196315

Attachment 366136: Patch

https://bugs.webkit.org/attachment.cgi?id=366136&action=review




--- Comment #7 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 366136
  --> https://bugs.webkit.org/attachment.cgi?id=366136
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366136&action=review

> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:2104
> +	   JSValue prototype = object->get(m_exec,
m_vm.propertyNames->prototype);
> +	   if (UNLIKELY(scope.exception()))
> +	       scope.clearException();

This isn't what you want.

You want JSObject::getPrototypeDirect. This is like asking for o.__proto__.

Doing what you're doing is o.prototype