[webkit-reviews] review granted: [Bug 195865] Web Inspector: Timeline: lazily create the agent : [Attachment 364981] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 18 13:15:43 PDT 2019

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 195865: Web Inspector: Timeline: lazily create the agent

Attachment 364981: Patch


--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 364981
  --> https://bugs.webkit.org/attachment.cgi?id=364981

View in context: https://bugs.webkit.org/attachment.cgi?id=364981&action=review


> Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp:719
> +    record->setString("frameId", pageAgent->frameId(frame));

Nit: "frameId"_s to use ASCIILiteral construction.

More information about the webkit-reviews mailing list