[webkit-reviews] review granted: [Bug 195859] Define the type of SVGPropertyOwnerRegistry for all SVG elements : [Attachment 364960] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 18 13:28:48 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 195859: Define the type of SVGPropertyOwnerRegistry for all SVG elements
https://bugs.webkit.org/show_bug.cgi?id=195859

Attachment 364960: Patch

https://bugs.webkit.org/attachment.cgi?id=364960&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 364960
  --> https://bugs.webkit.org/attachment.cgi?id=364960
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364960&action=review

> Source/WebCore/svg/SVGFEBlendElement.h:71
> +    using PropertyRegistry = SVGPropertyOwnerRegistry<SVGFEBlendElement,
SVGFilterPrimitiveStandardAttributes>;
> +    const SVGPropertyRegistry& propertyRegistry() const final { return
m_propertyRegistry; }
> +
> +    static bool isKnownAttribute(const QualifiedName& attributeName)
> +    {
> +	   return AttributeOwnerProxy::isKnownAttribute(attributeName) ||
PropertyRegistry::isKnownAttribute(attributeName);
> +    }

Lots of classes have this same boilerplate. Can it be pushed to a base class?


More information about the webkit-reviews mailing list