[webkit-reviews] review granted: [Bug 195897] [JSC] Add --destroy-vm shell option and dumpHeapStatisticsAtVMDestruction option : [Attachment 365034] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 195897: [JSC] Add --destroy-vm shell option and
dumpHeapStatisticsAtVMDestruction option
https://bugs.webkit.org/show_bug.cgi?id=195897

Attachment 365034: Patch

https://bugs.webkit.org/attachment.cgi?id=365034&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 365034
  --> https://bugs.webkit.org/attachment.cgi?id=365034
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365034&action=review

r=me with nits.

> Source/JavaScriptCore/ChangeLog:8
> +	   It is useful if we have an option logging the status of all the
existing MarkedBlock status and objects at VM destruction.

nit: existing MarkedBlock status and objects => existing MarkedBlocks and their
objects

> Source/JavaScriptCore/ChangeLog:9
> +	   I used this feature to find various wasting memory, and successfully
removed many of wasting MarkedBlocks and  JS cells like r243081.

nit: find various wasting memory, and successfully removed many of wasting
MarkedBlocks and JS cells => find wasted memory, and successfully removed many
wasted MarkedBlocks and JS cells