[webkit-reviews] review granted: [Bug 195898] Remove the inline capacity of Operands : [Attachment 365035] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 18 11:25:15 PDT 2019

Yusuke Suzuki <ysuzuki at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 195898: Remove the inline capacity of Operands

Attachment 365035: Patch


--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 365035
  --> https://bugs.webkit.org/attachment.cgi?id=365035

View in context: https://bugs.webkit.org/attachment.cgi?id=365035&action=review


> Source/JavaScriptCore/ChangeLog:11
> +	   Still on JetStream 2, functions have an average of 18 BB, but those
functions whose operands overflow have an average of 27 BB (so we are wasting
72kB on average when compiling them), and the largest function has 1241 BB (!),
for a total of 3.3MB being wasted while it is compiled.

I think FTL::OSRExitDescriptor also includes Operands, and it is kept alive
during the code is live :)

More information about the webkit-reviews mailing list