[webkit-reviews] review granted: [Bug 195840] [JSC] jsSubstring should resolve rope before calling JSRopeString::create : [Attachment 364899] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 195840: [JSC] jsSubstring should resolve rope before calling
JSRopeString::create
https://bugs.webkit.org/show_bug.cgi?id=195840

Attachment 364899: Patch

https://bugs.webkit.org/attachment.cgi?id=364899&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 364899
  --> https://bugs.webkit.org/attachment.cgi?id=364899
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364899&action=review

r=me

> Source/JavaScriptCore/ChangeLog:13
> +	   We can find that a lot of substrings for length = 1 are allocated in
RAMification regexp tests. This patch avoids creation of these

How much memory does this patch save?