[webkit-reviews] review granted: [Bug 195841] Have smaller default quotas for third party frames : [Attachment 364916] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 16 13:54:04 PDT 2019

Geoffrey Garen <ggaren at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 195841: Have smaller default quotas for third party frames

Attachment 364916: Patch


--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 364916
  --> https://bugs.webkit.org/attachment.cgi?id=364916

View in context: https://bugs.webkit.org/attachment.cgi?id=364916&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2342
> +	   auto quota = origin.topOrigin == origin.clientOrigin ?
storageQuotaManagers.defaultQuota : storageQuotaManagers.defaultQuota / 10;

Rather than dividing by 10, I think we want a thirdPartyQuota() helper function
to match the defaultQuota() helper function. That way, they’ll be next to each
other, and we’ll remember to update them together. (Dividing by 10 might not be
right in the future, if we reduce the default quota.)

More information about the webkit-reviews mailing list