[webkit-reviews] review granted: [Bug 195594] Web Inspector: Timelines - Improve handling of past recordings (readonly) : [Attachment 364330] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 11 19:09:47 PDT 2019

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 195594: Web Inspector: Timelines - Improve handling of past recordings

Attachment 364330: [PATCH] Proposed Fix


--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 364330
  --> https://bugs.webkit.org/attachment.cgi?id=364330
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=364330&action=review


> Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js:487
> +	   if (WI.timelineManager.activeRecording.readonly)
> +	       shouldCreateNewRecording = true;

Should we also change the tooltip of the record button to remove the
non-`shouldCreateNewRecording` text?  e.g. `"Start recording (%s)\nCreate new
recording (%s)"` becomes `"Create new recording (%s)"` when the active
recording is readonly (and vice versa).

More information about the webkit-reviews mailing list