[webkit-reviews] review granted: [Bug 195586] Add Optional to Forward.h. : [Attachment 364323] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 195586: Add Optional to Forward.h.
https://bugs.webkit.org/show_bug.cgi?id=195586

Attachment 364323: Patch

https://bugs.webkit.org/attachment.cgi?id=364323&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 364323
  --> https://bugs.webkit.org/attachment.cgi?id=364323
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364323&action=review

After a while I stopped commenting on all the different files where I think we
can omit the newly added includes of Forward.h, but I think we can remove most
of them.

> Source/JavaScriptCore/debugger/DebuggerParseData.h:30
> +#include <wtf/Forward.h>
>  #include <wtf/Vector.h>

Vector.h includes Forward.h so no need to add it.

> Source/JavaScriptCore/jit/PCToCodeOriginMap.h:33
> +#include <wtf/Forward.h>

Vector.h includes Forward.h so no need to add it.

> Source/JavaScriptCore/runtime/AbstractModuleRecord.h:30
> +#include <wtf/Forward.h>

ListHashSet.h includes HashSet.h which includes Forward.h so no need to add it.

> Source/JavaScriptCore/wasm/WasmStreamingParser.h:33
> +#include <wtf/Forward.h>

Vector.h includes Forward.h so no need to add it.

> Source/WTF/wtf/CPUTime.h:28
> +#include <wtf/Forward.h>

I think this include isn’t needed. Not 100% sure.

> Source/WebCore/Modules/encryptedmedia/MediaKeyStatusMap.h:36
> +#include <wtf/Forward.h>

Ref.h includes Forward.h so this include isn’t needed.

> Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:34
> +#include <wtf/Forward.h>

Vector.h includes Forward.h so this include isn’t needed.

> Source/WebCore/Modules/webauthn/apdu/ApduResponse.h:34
> +#include <wtf/Forward.h>

Vector.h includes Forward.h so this include isn’t needed.

> Source/WebCore/Modules/webauthn/fido/FidoHidMessage.h:37
> +#include <wtf/Forward.h>

Deque.h includes Vector.h which includes Forward.h so this include isn’t
needed.

> Source/WebCore/Modules/webdatabase/SQLTransaction.h:37
> +#include <wtf/Forward.h>

Deque.h includes Vector.h which includes Forward.h so this include isn’t
needed.

> Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLEntryPointScaffolding.h:32
> +#include <wtf/Forward.h>

HashMap.h includes Forward.h so this include isn’t needed.

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h:31
> +#include <wtf/Forward.h>

Vector.h includes Forward.h so this include isn’t needed.

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLPrepare.h:32
> +#include <wtf/Forward.h>

WTFString.h includes something that includes Forward.h so this include isn’t
needed.

> Source/WebCore/Modules/webgpu/WebGPU.h:31
> +#include <wtf/Forward.h>

Guessing this isn’t needed, not sure.

> Source/WebCore/Modules/webgpu/WebGPUCommandBuffer.h:35
> +#include <wtf/Forward.h>
>  #include <wtf/Ref.h>
>  #include <wtf/RefCounted.h>
>  #include <wtf/RefPtr.h>

RefPtr.h includes Ref.h, and that in turn includes Forward.h so both Forward.h
and Ref.h includes can be deleted here.

> Source/WebCore/animation/WebAnimation.h:35
>  #include <wtf/Ref.h>

Could delete this since RefPtr.h includes Ref.h.

> Source/WebCore/dom/TextDecoder.h:30
> +#include <wtf/Forward.h>

No need for this since WTFString.h already includes it.

> Source/WebCore/dom/UserGestureIndicator.h:29
> +#include <wtf/Forward.h>

No need, this includes Vector.h and other headers that take care of Forward.h.

> Source/WebCore/html/HTMLAllCollection.h:29
> +#include <wtf/Forward.h>

Seems likely this can be omitted, but not sure.