[webkit-reviews] review granted: [Bug 195248] Web Inspector: DOMDebugger: protocol error on first open : [Attachment 363859] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 195248: Web Inspector: DOMDebugger: protocol error on first open
https://bugs.webkit.org/show_bug.cgi?id=195248

Attachment 363859: Patch

https://bugs.webkit.org/attachment.cgi?id=363859&action=review




--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 363859
  --> https://bugs.webkit.org/attachment.cgi?id=363859
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363859&action=review

r=me

> Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js:180
> +	   if (!breakpoint.disabled) {
> +	       this._updateDOMBreakpoint(breakpoint, WI.assumingMainTarget());
> +	   }

Style: No braces

> Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js:256
> +	       for (let target of WI.targets)
> +		   this._updateEventBreakpoint(breakpoint, target);

It would make more sense to me to put the if (target.DOMDebuggerAgent) here in
this loop then buried in _updateEventBreakpoint. It could be an assert there.

> Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js:328
> +	       for (let target of WI.targets)
> +		   this._updateURLBreakpoint(breakpoint, target);

It would make more sense to me to put the if (target.DOMDebuggerAgent) here in
this loop then buried in _updateURLBreakpoint. It could be an assert there.

> Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js:542
> +	   for (let target of WI.targets)
> +	       this._updateDOMBreakpoint(breakpoint, target);

It would make more sense to me to put the if (target.DOMDebuggerAgent) here in
this loop then buried in _updateDOMBreakpoint. It could be an assert there.

> Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js:549
> +	   for (let target of WI.targets)

Ditto

> Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js:561
> +	   for (let target of WI.targets)

Ditto