[webkit-reviews] review granted: [Bug 195390] Web Inspector: CPU Usage Timeline - Add legend and graph hover effects : [Attachment 364238] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 195390: Web Inspector: CPU Usage Timeline - Add legend and graph hover
effects
https://bugs.webkit.org/show_bug.cgi?id=195390

Attachment 364238: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=364238&action=review




--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 364238
  --> https://bugs.webkit.org/attachment.cgi?id=364238
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=364238&action=review

r=me, awesome work!  Thanks for iterating :)

> Source/WebInspectorUI/UserInterface/Views/AreaChart.js:90
> +    addPointMarker(x, y)

NIT: I don't know why I didn't mention this earlier, but I feel like this could
be shortened to just `addMarker`.

> Source/WebInspectorUI/UserInterface/Views/AreaChart.js:95
> +    clearPointMarkers()

Ditto (>90), but with `clearMarkers`.