[webkit-reviews] review granted: [Bug 195335] Web Inspector: CSS: there should be a way to inline-replace a variable with it's value : [Attachment 363688] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 195335: Web Inspector: CSS: there should be a way to inline-replace a
variable with it's value
https://bugs.webkit.org/show_bug.cgi?id=195335

Attachment 363688: Patch

https://bugs.webkit.org/attachment.cgi?id=363688&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 363688
  --> https://bugs.webkit.org/attachment.cgi?id=363688
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363688&action=review

r=me.

The Shift+Click is hard to discover, even with a tooltip, but this is quite
good for now.

>> Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js:199
>> +		return;
> 
> I don't think SpreadsheetTextField should know about WI.InlineSwatch.
> Can we call `event.stopPropagation()` in
WI.InlineSwatch.prototype._swatchElementClicked?

I like this idea as well, it makes sense for the InlineSwatch to consume the
click.