[webkit-reviews] review granted: [Bug 195265] Web Inspector: Audit: there should be a centralized place for reusable code : [Attachment 363529] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 195265: Web Inspector: Audit: there should be a centralized place for
reusable code
https://bugs.webkit.org/show_bug.cgi?id=195265

Attachment 363529: Patch

https://bugs.webkit.org/attachment.cgi?id=363529&action=review




--- Comment #19 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 363529
  --> https://bugs.webkit.org/attachment.cgi?id=363529
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363529&action=review

Awesome! r=me

> LayoutTests/inspector/audit/manager-start-setup.html:86
> +	   description: "Check that Audit.run is able to respond with a
RemoteObject.",

Some of these descriptions are a little generic given this is testing nested
behavior.

> LayoutTests/inspector/audit/manager-start-setup.html:98
> +	   async test() {
> +	       const setupA = (function() {
> +		   WebInspectorAudit.__test = "A";
> +	       }).toString();
> +
> +	       const setupB = (function() {
> +		   WebInspectorAudit.__test = "B";
> +	       }).toString();
> +
> +	       let audit = new
WI.AuditTestGroup("AuditManager.prototype.start.OverriddenLevelSetup.Group", [
> +		   new
WI.AuditTestCase("AuditManager.prototype.start.OverriddenLevelSetup.Test",
auditTestString, {setup: setupA}),
> +	       ], {setup: setupB});

Do I understand correctly that both of these setup's ran, and "A" ran first and
was overridden by "B".

So our chain is only the Top Level setup, and the per-test Setup, but no
additional groups in between?