[webkit-reviews] review granted: [Bug 148049] Web Inspector: Unexpectedly frequent flashing of DOM node attributes : [Attachment 358113] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 148049: Web Inspector: Unexpectedly frequent flashing of DOM node
attributes
https://bugs.webkit.org/show_bug.cgi?id=148049

Attachment 358113: Patch

https://bugs.webkit.org/attachment.cgi?id=358113&action=review




--- Comment #11 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 358113
  --> https://bugs.webkit.org/attachment.cgi?id=358113
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358113&action=review

r=me, this seems to address the majority of flashing issues.

I do still see poor animations on frequently updating elements, perhaps based
on the resolution of performance.now()?

Visible in just the seconds element of:

    <span id="time" title="?">
	<span id="minutes">?</span>:<span id="seconds">?</span>
    </span>
    <script>
    setInterval(function() {
	var date = new Date;
	minutes.textContent = minutes.title = date.getMinutes();
	seconds.textContent = seconds.title = date.getSeconds();
    }, 1000/60);
    </script>

90% of the time the animation works as expected, but sometimes it does not.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:274
> +	       element: null,

We could put `listener: null` as well.