[webkit-reviews] review granted: [Bug 199195] Perform less work when a pre-warmed WebProcess is suspended or resumed. : [Attachment 373186] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 30 13:14:14 PDT 2019

Darin Adler <darin at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 199195: Perform less work when a pre-warmed WebProcess is suspended or

Attachment 373186: Patch


--- Comment #17 from Darin Adler <darin at apple.com> ---
Comment on attachment 373186
  --> https://bugs.webkit.org/attachment.cgi?id=373186

View in context: https://bugs.webkit.org/attachment.cgi?id=373186&action=review

> Source/WebKit/WebProcess/WebProcess.h:-552
>      enum class ProcessType { Inspector, ServiceWorker, PrewarmedWebContent,
CachedWebContent, WebContent };
>      ProcessType m_processType { ProcessType::WebContent };
> -#endif

What motivates this change? The rest of the m_processType code is inside #if
PLATFORM(MAC/COCOA/IOS_FAMILY) conditionals. That includes code in WebProcess
functions initializeWebProcess, setIsInProcessCache, and
markIsNoLongerPrewarmed. Why the change in strategy only for this newly written
code? We could have removed some of those other conditionals too if we are
deciding to change our conditionals strategy.

Typically I would suggest staying with the #if PLATFORM(COCOA) or remove more
of it, not leave it mixed.

More information about the webkit-reviews mailing list