[webkit-reviews] review granted: [Bug 199066] [GTK] Stop pretending WebCore::Widget can have a platform widget : [Attachment 372550] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 20 06:56:01 PDT 2019

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 199066: [GTK] Stop pretending WebCore::Widget can have a platform widget

Attachment 372550: Patch


--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 372550
  --> https://bugs.webkit.org/attachment.cgi?id=372550

View in context: https://bugs.webkit.org/attachment.cgi?id=372550&action=review

Wow, this survived a really long time.

> Source/WebKit/ChangeLog:8
> +	   Rename PlatformWidget as PlatformViewWidget to avoid conflict with
PlatformWidget defined in WebCore.

Perhaps you hit a unified build issue? WebCore::PlatformWidget and
WebKit::PlatformWidget are not the same and should not conflict except when a
source file that is using namespace WebCore; gets unified into another source
file that isn't expecting it.

Anyway, this change is harmless and I think we can skirt the owner rules if
it's a build issue.

More information about the webkit-reviews mailing list