[webkit-reviews] review granted: [Bug 199057] [LFC][IFC] Make the initial strut explicit : [Attachment 372529] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 199057: [LFC][IFC] Make the initial strut explicit
https://bugs.webkit.org/show_bug.cgi?id=199057

Attachment 372529: Patch

https://bugs.webkit.org/attachment.cgi?id=372529&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 372529
  --> https://bugs.webkit.org/attachment.cgi?id=372529
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372529&action=review

>
Source/WebCore/layout/inlineformatting/InlineFormattingContextLineLayout.cpp:13
7
>      auto initialLineConstraints = Line::InitialConstraints {
>	   lineInput.horizontalConstraint.logicalTopLeft,
>	   lineInput.horizontalConstraint.availableLogicalWidth,
> -	   mimimumLineHeight,
> -	   initialBaselineOffset
> +	   heightConstraints.height,
> +	   heightConstraints.baselineOffset,
> +	   heightConstraints.strut
>      };

Should InitialConstraints just have HeightConstraints member?