[webkit-reviews] review granted: [Bug 197917] REGRESSION (r245043) [Mac WK2 Debug] ASSERTION FAILED: m_services.isEmpty() && transports.size() <= maxTransportNumber seen with two http/wpt/webauthn/public-key-credential-* tests : [Attachment 371918] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 197917: REGRESSION (r245043) [Mac WK2 Debug] ASSERTION FAILED:
m_services.isEmpty() && transports.size() <= maxTransportNumber seen with two
http/wpt/webauthn/public-key-credential-* tests
https://bugs.webkit.org/show_bug.cgi?id=197917

Attachment 371918: Patch

https://bugs.webkit.org/attachment.cgi?id=371918&action=review




--- Comment #14 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 371918
  --> https://bugs.webkit.org/attachment.cgi?id=371918
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371918&action=review

>>> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:178
>>> +	     return;
>> 
>> I'm not sure I follow this new behavior. Does calling the completion handler
(e.g., lines 132 and 152 above) cause the completion handler to be cleared? I
guess it must.
> 
> Yes, it does. And m_pendingCompletionHandler should be called before every
clearState(). Therefore, if clearState() is called with
m_pendingCompletionHandler, that means clearState() is called from
clearStateAsync() and there is currently an active request. Therefore, the
method should just return.

Okay -- makes sense.