[webkit-reviews] review granted: [Bug 198766] Add assertions to help debug crash at WebKit::HistoryEntryDataEncoder::operator<< : [Attachment 371968] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 198766: Add assertions to help debug crash at
WebKit::HistoryEntryDataEncoder::operator<<
https://bugs.webkit.org/show_bug.cgi?id=198766

Attachment 371968: Patch

https://bugs.webkit.org/attachment.cgi?id=371968&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 371968
  --> https://bugs.webkit.org/attachment.cgi?id=371968
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371968&action=review

r=me

> Source/WebKit/Shared/SessionState.h:116
> +    bool isDestructed { false };
> +    ~FrameState() { isDestructed = true; }

This probably deserves a comment that it's only here to help debug an
undiagnosed bug, with a Bugzilla or Radar link.