[webkit-reviews] review granted: [Bug 198741] waitForNavigationToComplete may be called before WebPageProxy knows it's loading : [Attachment 371820] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 11 13:32:33 PDT 2019
Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 198741: waitForNavigationToComplete may be called before WebPageProxy knows
it's loading
https://bugs.webkit.org/show_bug.cgi?id=198741
Attachment 371820: Patch
https://bugs.webkit.org/attachment.cgi?id=371820&action=review
--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 371820
--> https://bugs.webkit.org/attachment.cgi?id=371820
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=371820&action=review
Makes sense to me. r=me
> Source/WebKit/ChangeLog:12
> + If the timing of the communications to the `WebPageProxy` about the
fact that it's actually
> + `PageLoadingState::isLoading` is too "slow" or happens after
> + `WebAutomationSession::waitForNavigationToCompleteOnPage` is called,
the automation session
> + will continue running commands, which can lead to a JavaScript error
("Callback was not
This seems a bit complex. It just sounds like there is a race between
waitForNavigationToCompleteOnPage and PageLoadingState isLoading in provisional
loads, and this better addresses it.
> Source/WebKit/UIProcess/PageLoadState.h:128
> + bool isLoadingUncommitted() const;
I wonder if a better name might be `isPerfomingProvisionalLoad()` or just a
general `isPerformingLoad` which checks committed / uncommitted. Maybe the
networking guys have a better suggestion given they work in this area more
often.
More information about the webkit-reviews
mailing list