[webkit-reviews] review granted: [Bug 198764] LayoutTests/fast/events/touch/ios/double-tap-for-double-click* test cases are failing : [Attachment 371871] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted zalan <zalan at apple.com>'s
request for review:
Bug 198764: LayoutTests/fast/events/touch/ios/double-tap-for-double-click* test
cases are failing
https://bugs.webkit.org/show_bug.cgi?id=198764

Attachment 371871: Patch

https://bugs.webkit.org/attachment.cgi?id=371871&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 371871
  --> https://bugs.webkit.org/attachment.cgi?id=371871
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371871&action=review

r=mews

> Source/WebKit/Shared/WebPageCreationParameters.cpp:295
> +    if (!decoder.decode(parameters.doubleClickForDoubleTapDelay))

Nit - doubleTapForDoubleClick* sounds a bit more appropriate.

> Source/WebKit/Shared/WebPageCreationParameters.h:161
> +    double doubleClickForDoubleTapDelay { 350 };

Nit - Seconds

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:809
> +    auto distanceBetweenTaps = sqrtf(pow(m_potentialTapLocation.x() -
m_lastCommittedTapLocation.x(), 2) + pow(m_potentialTapLocation.y() -
m_lastCommittedTapLocation.y(), 2));

Nit - you could probably just subtract the points and use
diagonalLengthSquared.