[webkit-reviews] review granted: [Bug 198613] Use default toolchain in ASan xcconfig : [Attachment 371507] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 198613: Use default toolchain in ASan xcconfig
https://bugs.webkit.org/show_bug.cgi?id=198613

Attachment 371507: Patch

https://bugs.webkit.org/attachment.cgi?id=371507&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 371507
  --> https://bugs.webkit.org/attachment.cgi?id=371507
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371507&action=review

> Tools/ChangeLog:3
> +	   Use default toolchain in ASan xcconfig

I would call this "remove obsolete TOOLCHAINS overrides from asan.xcconfig".
Unfortunately, "default" has two distinct meanings in this context - one is
"default", and another what Xcode defaults to. As you can see, older OSes
required changing the default to "default".