[webkit-reviews] review granted: [Bug 179022] Implement tab-size with units : [Attachment 371477] Apply Simon's comments

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Joonghun Park
<jh718.park at samsung.com>'s request for review:
Bug 179022: Implement tab-size with units
https://bugs.webkit.org/show_bug.cgi?id=179022

Attachment 371477: Apply Simon's comments

https://bugs.webkit.org/attachment.cgi?id=371477&action=review




--- Comment #17 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 371477
  --> https://bugs.webkit.org/attachment.cgi?id=371477
Apply Simon's comments

View in context: https://bugs.webkit.org/attachment.cgi?id=371477&action=review

> Source/WebCore/css/StyleBuilderConverter.h:260
> +inline TabSize StyleBuilderConverter::convertLengthOrTabSpaces(const
StyleResolver& styleResolver, const CSSValue& value)

I think this should just be called convertTabSize()

> Source/WebCore/platform/graphics/TabSize.h:58
> +    float m_floatValue;

m_value

> LayoutTests/css3/tab-size.html:16
> +.int-tab-size {
> +  tab-size: 9;
> +}

What about fractional tab sizes: tab-size: 2.5 ?