[webkit-reviews] review granted: [Bug 198581] AI should get GetterSetter structure from the base's GlobalObject for GetGetterSetterByOffset : [Attachment 371438] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 198581: AI should get GetterSetter structure from the base's GlobalObject
for GetGetterSetterByOffset
https://bugs.webkit.org/show_bug.cgi?id=198581

Attachment 371438: Patch

https://bugs.webkit.org/attachment.cgi?id=371438&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 371438
  --> https://bugs.webkit.org/attachment.cgi?id=371438
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371438&action=review

r=me

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:3331
> +	   setTypeForNode(node, SpecObjectOther);

can you add a test for this when we don't constant fold? I think if you run
with validateAIState option it should fail in the FTL if you have a test where
you create a bunch of global objects.