[webkit-reviews] review granted: [Bug 198014] aarch64: ‘JSC::ARM64Assembler::LinkRecord::<unnamed union>::RealTypes::m_compareRegister’ is too small to hold all values of ‘JSC::ARM64Assembler::RegisterID’ {aka ‘enum JSC::ARM64Registers::RegisterID’} : [Attachment 371434] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 5 14:54:20 PDT 2019


Yusuke Suzuki <ysuzuki at apple.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 198014: aarch64: ‘JSC::ARM64Assembler::LinkRecord::<unnamed
union>::RealTypes::m_compareRegister’ is too small to hold all values of
‘JSC::ARM64Assembler::RegisterID’ {aka ‘enum JSC::ARM64Registers::RegisterID’}
https://bugs.webkit.org/show_bug.cgi?id=198014

Attachment 371434: Patch

https://bugs.webkit.org/attachment.cgi?id=371434&action=review




--- Comment #5 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 371434
  --> https://bugs.webkit.org/attachment.cgi?id=371434
Patch

r=me. If we can shrink LinkRecord, we should represent the register in a bit
fields, but in this case, it does not matter much, sizeof(LinkedRecord) does
not change.


More information about the webkit-reviews mailing list