[webkit-reviews] review granted: [Bug 197132] Progress towards resurrecting Mac CMake build : [Attachment 371430] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 197132: Progress towards resurrecting Mac CMake build
https://bugs.webkit.org/show_bug.cgi?id=197132

Attachment 371430: Patch

https://bugs.webkit.org/attachment.cgi?id=371430&action=review




--- Comment #10 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 371430
  --> https://bugs.webkit.org/attachment.cgi?id=371430
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371430&action=review

r=me looks like a good start! Only concern is the library path.

One thing I could use assistance with is creating a Find module for Apple
specific frameworks for Apple builds (Win and Mac). Pop on IRC to discuss
sometime.

> Source/cmake/target/icu.cmake:-3
> -if (NOT TARGET ICU::data)

Any reason for getting rid of the `if (NOT TARGET ICU::data)`? was something
failing for you? Its fine as long as this is only included once.

> Source/cmake/target/icu.cmake:9
> +    set(ICU_I18N_LIBRARY /usr/lib/libicucore.dylib)
> +    set(ICU_UC_LIBRARY /usr/lib/libicucore.dylib)
> +    set(ICU_DATA_LIBRARY /usr/lib/libicucore.dylib)

Is this always the path? Should we use a find_library for icucore.dylib in a
private variable and then just set everything using that?