[webkit-reviews] review granted: [Bug 198391] Add support of zxcvbn password strength checker to bugs.webkit.org website. : [Attachment 371428] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted lingho at apple.com
<lingho at apple.com>'s request for review:
Bug 198391: Add support of zxcvbn password strength checker to bugs.webkit.org
website.
https://bugs.webkit.org/show_bug.cgi?id=198391

Attachment 371428: Patch

https://bugs.webkit.org/attachment.cgi?id=371428&action=review




--- Comment #6 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 371428
  --> https://bugs.webkit.org/attachment.cgi?id=371428
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371428&action=review

r=me, but please fix the [% error filter html %] issue at minimum.  After that,
this is good to go.

> Websites/bugs.webkit.org/Bugzilla/User.pm:2495
> +	   return 'Password is weak. ' . $est_strength->{feedback}->{warning} .
'. '

Nit:  Format of this message is not like the others; would like something like
`password_too_weak_SCORE' where "SCORE" is replaced with the numeric score,
then you could change the template to pull out the score (which may not even be
needed--if so, just drop "_SCORE" from the return value) and write the text to
display to the user there (which would be easier to translate if we cared about
this).

You can land the patch without this change, but please consider it.

> Websites/bugs.webkit.org/template/en/default/global/user-error.html.tmpl:1468
> +    [% error %]

This should be:

    [% error filter html %]